Skip to content

CLN remove unnecessary trailing commas from aggregation #35930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2020
Merged

CLN remove unnecessary trailing commas from aggregation #35930

merged 1 commit into from
Aug 28, 2020

Conversation

MarcoGorelli
Copy link
Member

xref #35925

@MarcoGorelli MarcoGorelli changed the title remove unnecessary trailing commas CLN remove unnecessary trailing commas Aug 27, 2020
@MarcoGorelli MarcoGorelli mentioned this pull request Aug 27, 2020
Closed
23 tasks
@MarcoGorelli MarcoGorelli changed the title CLN remove unnecessary trailing commas CLN remove unnecessary trailing commas from aggregation Aug 27, 2020
@bashtage bashtage mentioned this pull request Aug 27, 2020
Closed
charlesdong1991
charlesdong1991 approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@charlesdong1991 charlesdong1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could also tick the corresponding one in the issue?

@charlesdong1991 charlesdong1991 added this to the 1.2 milestone Aug 27, 2020
@MarcoGorelli MarcoGorelli removed the Docs label Aug 28, 2020
@simonjayhawkins simonjayhawkins merged commit 328a1dc into pandas-dev:master Aug 28, 2020
@simonjayhawkins
Copy link
Member

Thanks @MarcoGorelli

@simonjayhawkins simonjayhawkins added the Code Style Code style, linting, code_checks label Aug 28, 2020
@MarcoGorelli MarcoGorelli deleted the issue35925-aggregation branch August 28, 2020 16:50
AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Aug 31, 2020
@MarcoGorelli @AlexKirko
remove unnecessary trailing commas (pandas-dev#35930)
fba43cb
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@MarcoGorelli
remove unnecessary trailing commas (pandas-dev#35930)
110d5c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@charlesdong1991 charlesdong1991 charlesdong1991 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Clean Code Style Code style, linting, code_checks

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcoGorelli @simonjayhawkins @charlesdong1991